Open sevdog opened 4 months ago
Currently what is stated in the docs is not aligned with what the code does: https://github.com/jazzband/django-smart-selects/blob/1f3ac7c08a31d2e8cc792f1de484a027a25eef1f/docs/settings.md?plain=1#L3-L10
https://github.com/jazzband/django-smart-selects/blob/1f3ac7c08a31d2e8cc792f1de484a027a25eef1f/smart_selects/widgets.py#L16-L51
Also there are no tests which ensures this beaviour.
The issues are:
JQUERY_URL=True
True
USE_DJANGO_JQUERY
JQUERY_URL
False
None
Some tests over this feature are required and also the docs should be more accurate.
Currently what is stated in the docs is not aligned with what the code does: https://github.com/jazzband/django-smart-selects/blob/1f3ac7c08a31d2e8cc792f1de484a027a25eef1f/docs/settings.md?plain=1#L3-L10
https://github.com/jazzband/django-smart-selects/blob/1f3ac7c08a31d2e8cc792f1de484a027a25eef1f/smart_selects/widgets.py#L16-L51
Also there are no tests which ensures this beaviour.
The issues are:
JQUERY_URL=True
it results in having aTrue
as JS source, which ends up in an errore on frontendUSE_DJANGO_JQUERY
theJQUERY_URL
should be a falsy value different fromFalse
(ie: empty string, 0,None
, etc...)JQUERY_URL=True
will make this package use the Google CDN, while this works if the settings is not definedSome tests over this feature are required and also the docs should be more accurate.