jazzband / django-taggit

Simple tagging for django
https://django-taggit.readthedocs.io
BSD 3-Clause "New" or "Revised" License
3.34k stars 622 forks source link

TaggableManager doesn't base itself off of RelatedManager #803

Open rtpg opened 2 years ago

rtpg commented 2 years ago

TaggableManager is, essentially, a RelatedManager in spirit. It's fetching data off of a related table, has its prefetch cache.

Over the years we've had a couple bugs (#802 , #686 ) due to us not relying on RelatedManager and just reproducing features ad-hoc.

I haven't deeply looked into the feasibility of using RelatedManager directly. But if it's doable, it would be very good in my opinion. We might still need to do some magic to maintain some backwards compat.