jazzband / django-taggit

Simple tagging for django
https://django-taggit.readthedocs.io
BSD 3-Clause "New" or "Revised" License
3.33k stars 622 forks source link

Make TagListSerializerField subclass ListField #833

Closed rtpg closed 1 year ago

rtpg commented 1 year ago

This is a very tricky change, and I expect some issues once people begin using this in earnest. But it is closer to where we want to be, and the main functionality is being tested.

This change is motivated by documentation tools not properly identifying this field as a ListField.

This also includes ome documentation tweaks in the changelog

Thanks to @brittandeyoung for the initial PR

Fixes #828

codecov[bot] commented 1 year ago

Codecov Report

Merging #833 (54cb1cc) into master (bdf7236) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #833   +/-   ##
=======================================
  Coverage   95.81%   95.81%           
=======================================
  Files           3        3           
  Lines         454      454           
  Branches       96       96           
=======================================
  Hits          435      435           
  Misses         12       12           
  Partials        7        7           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

brittandeyoung commented 1 year ago

@rtpg Yeah this looks great! I am already using a custom class with the listfield in my app and it is working great. Will be nice to be able to use this instead.

rtpg commented 1 year ago

the codecov reprot incorrectly reported a coverage drop, but that went back to 0% change.