jazzband / django-taggit

Simple tagging for django
https://django-taggit.readthedocs.io
BSD 3-Clause "New" or "Revised" License
3.33k stars 622 forks source link

Django Taggit 5.0 is not compatible with Django <4.1 #875

Closed bartTC closed 11 months ago

bartTC commented 11 months ago

The latest 0006 migration uses the migrations.RenameIndex method which has been introduced in Django v4.1. Running it on Django 3.2 will result in error below:

AttributeError: module 'django.db.migrations' has no attribute 'RenameIndex'. Did you mean: 'RemoveIndex'?

The minimum Django version here should be raised accordingly to prevent installing it automatically.

rtpg commented 11 months ago

Thank you for catching this! Totally a mistake on my part.

rtpg commented 11 months ago

made a new release (5.0.1) without this issue, and looking at yanking 5.0.0 to avoid it getting proposed in Django 3.2.

bartTC commented 11 months ago

Thank you! Yes, I think 5.0.0 should be yanked, as it still indicates it's the last version that is compatible with Django 3.2.

❯ echo "django==3.2.22\ndjango-taggit" | pip-compile --upgrade -o /tmp/test.txt -
WARNING: --strip-extras is becoming the default in version 8.0.0. To silence this warning, either use --strip-extras to opt into the new default or use --no-strip-extras to retain the existing behavior.
#
# This file is autogenerated by pip-compile with Python 3.12
# by the following command:
#
#    pip-compile --output-file=/tmp/test.txt -
#
asgiref==3.7.2
    # via django
django==3.2.22
    # via
    #   -r -
    #   django-taggit
django-taggit==5.0.0
    # via -r -
pytz==2023.3.post1
    # via django
sqlparse==0.4.4
    # via django
rtpg commented 11 months ago

Was yanked, this should now be a non-issue