search

jazzband / django-tinymce

TinyMCE integration for Django
http://django-tinymce.readthedocs.org/
MIT License
1.29k stars 316 forks source link

Migrate to GitHub Actions. #340

Closed jezdez closed 3 years ago

jezdez commented 3 years ago

Travis CI has a new pricing model which places limits on open source.

Many projects are moving to GitHub Actions instead, including Jazzband projects:

This is based on https://github.com/jazzband/contextlib2/pull/26.

Fix #329.

TODO:

Natim commented 3 years ago

I'm currious of why removing the Makefile though?

jezdez commented 3 years ago

I'm currious of why removing the Makefile though?

Not a huge reason other than Makefiles tend to collect dust and it doesn't map to the tox config as nicely, adding duplication. I can re-add it though, no strong feelings other than "let's get this migrated".

codecov[bot] commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b73c832). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #340   +/-   ##
=========================================
  Coverage          ?   88.50%           
=========================================
  Files             ?        6           
  Lines             ?      287           
  Branches          ?       50           
=========================================
  Hits              ?      254           
  Misses            ?       15           
  Partials          ?       18

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b73c832...5e8e40c. Read the comment docs.

jezdez commented 3 years ago

@Natim I've added a separate workflow for running pre-commit but wondered if you'd be interested in trialing the use of https://pre-commit.ci?

jezdez commented 3 years ago

Thanks a lot for working on this. I'm not yet familiar with GH actions, so I'm mostly trusting you!

Thank you, this is a pretty conservative way to do GitHub Actions, and we have now ~40 other Jazzband projects doing a very similar setup. I'm a bit more skeptical to have a 3rd party service for pre-commit (since it's what has screwed us with Travis CI), but since it's from the pre-commit author I think it may be worth a shot.