search

jazzband / django-tinymce

TinyMCE integration for Django
http://django-tinymce.readthedocs.org/
MIT License
1.25k stars 317 forks source link

Migrate from TinyMCE 5 to TinyMCE 6 #457

Closed claudep closed 4 months ago

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5e4d420) 90.20% compared to head (945d572) 87.14%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #457 +/- ## ========================================== - Coverage 90.20% 87.14% -3.07% ========================================== Files 6 6 Lines 286 249 -37 Branches 51 45 -6 ========================================== - Hits 258 217 -41 - Misses 12 15 +3 - Partials 16 17 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

claudep commented 4 months ago

We'll see if we get more testing inside master tree.

marius-mather commented 3 months ago

@claudep I am trying out the version from master in my project and it seems to be working well for me, although my requirements are fairly simple - basically just doing some configuration of the editor toolbar, and using HtmlField to store it in my models.

An official release would be great - I was using https://github.com/django-ckeditor/django-ckeditor but that is now stuck on an insecure, unsupported version, and this would be a good replacement.

claudep commented 3 months ago

Thanks a lot for the feedback! I guess that #460 is still more or less a blocker, and should be solved (either by upstream or us removing the offending lines) before pushing a new release.