Closed pre-commit-ci[bot] closed 1 week ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 87.14%. Comparing base (
eac5cc3
) to head (adf2e5c
). Report is 2 commits behind head on master.:exclamation: Current head adf2e5c differs from pull request most recent head 086f9f6
Please upload reports for the commit 086f9f6 to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@claudep should we merge this PR, what is the policy in Jazzband regarding those PRs? Can I approve and merge it myself?
My personal position on this is that they pollute the git history for almost no gain, so generally I prefer merging them just before making a new release. I know other maintainers always merge them almost immediately. Tastes and such :cake:
I agree with you, it does not provide much value to the code base at this stage so lets do it in a later stage.
updates: