jazzband / django-tinymce

TinyMCE integration for Django
http://django-tinymce.readthedocs.org/
MIT License
1.25k stars 317 forks source link

[pre-commit.ci] pre-commit autoupdate #458

Closed pre-commit-ci[bot] closed 1 week ago

pre-commit-ci[bot] commented 4 months ago

updates:

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.14%. Comparing base (eac5cc3) to head (adf2e5c). Report is 2 commits behind head on master.

:exclamation: Current head adf2e5c differs from pull request most recent head 086f9f6

Please upload reports for the commit 086f9f6 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #458 +/- ## ======================================= Coverage 87.14% 87.14% ======================================= Files 6 6 Lines 249 249 Branches 45 45 ======================================= Hits 217 217 Misses 15 15 Partials 17 17 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Pantzan commented 2 weeks ago

@claudep should we merge this PR, what is the policy in Jazzband regarding those PRs? Can I approve and merge it myself?

claudep commented 2 weeks ago

My personal position on this is that they pollute the git history for almost no gain, so generally I prefer merging them just before making a new release. I know other maintainers always merge them almost immediately. Tastes and such :cake:

Pantzan commented 2 weeks ago

I agree with you, it does not provide much value to the code base at this stage so lets do it in a later stage.