search

jazzband / django-tinymce

TinyMCE integration for Django
http://django-tinymce.readthedocs.org/
MIT License
1.25k stars 317 forks source link

Remove sourceMappingURL lines from tinymce static files #461

Closed marius-mather closed 3 months ago

marius-mather commented 3 months ago

Closes #460 . This is just a workaround, the "ideal" solution is that TinyMCE either ships the .map files in their releases or removes references to them. But probably the easiest fix for now.

claudep commented 3 months ago

Thanks, it's probably the best move for now. Do you think we could add a regression test for that, so we don't forget to reapply this in future lib updates, if the upstream project doesn't fix this issue?

marius-mather commented 3 months ago

I've added a test that just tries to run collectstatic with the built-in ManifestStaticFilesStorage - it fails when the source map issue is encountered.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.14%. Comparing base (f04e1c8) to head (e0f4b9f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #461 +/- ## ======================================= Coverage 87.14% 87.14% ======================================= Files 6 6 Lines 249 249 Branches 45 45 ======================================= Hits 217 217 Misses 15 15 Partials 17 17 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

claudep commented 3 months ago

Thanks!