search

jazzband / django-two-factor-auth

Complete Two-Factor Authentication for Django providing the easiest integration into most Django projects.
MIT License
1.71k stars 448 forks source link

move get_username to function for cleaner subclassing #612

Closed RyanHope closed 1 year ago

RyanHope commented 1 year ago

Motivation: I want to show the users email address not their username and this makes subclassing the qr generator cleaner.

codecov[bot] commented 1 year ago

Codecov Report

Merging #612 (b7806d7) into master (6377d6c) will increase coverage by 0.00%. The diff coverage is 71.42%.

@@           Coverage Diff           @@
##           master     #612   +/-   ##
=======================================
  Coverage   95.43%   95.43%           
=======================================
  Files          74       74           
  Lines        3195     3198    +3     
  Branches      358      358           
=======================================
+ Hits         3049     3052    +3     
  Misses        117      117           
  Partials       29       29
Impacted Files Coverage Δ
two_factor/views/core.py 96.69% <71.42%> (+0.02%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more