jazzband / django-two-factor-auth

Complete Two-Factor Authentication for Django providing the easiest integration into most Django projects.
MIT License
1.71k stars 448 forks source link

Refs #587 - Avoid importing phonenumber stuff in main migrations #620

Closed claudep closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #620 (e2cb4d0) into master (a35a7f9) will decrease coverage by 0.01%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #620      +/-   ##
==========================================
- Coverage   95.46%   95.45%   -0.01%     
==========================================
  Files          74       74              
  Lines        3198     3192       -6     
  Branches      358      222     -136     
==========================================
- Hits         3053     3047       -6     
  Misses        116      116              
  Partials       29       29              

see 2 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

mgax commented 1 year ago

FWIW, the migration file two_factor/migrations/0009_initial.py is still being generated, because of the URLs in two_factor/urls.py. If I remove them too, no migration is generated any more.

claudep commented 1 year ago

Sure, this is not sufficient to solve the migration issue. However I separated from #596 as this is IMHO not subject to any discussion, while the rest of the #596 PR might have some backwards compatibility issues.

claudep commented 1 year ago

Thanks @peymanslh !