search

jazzband / django-two-factor-auth

Complete Two-Factor Authentication for Django providing the easiest integration into most Django projects.
MIT License
1.71k stars 448 forks source link

Prepare the 1.15.3 release #631

Closed claudep closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #631 (9bbd6fe) into master (6150a78) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #631   +/-   ##
=======================================
  Coverage   95.46%   95.47%           
=======================================
  Files          74       75    +1     
  Lines        3198     3204    +6     
  Branches      358      359    +1     
=======================================
+ Hits         3053     3059    +6     
  Misses        116      116           
  Partials       29       29
Impacted Files Coverage Δ
two_factor/plugins/phonenumber/apps.py 100.00% <100.00%> (ø)
two_factor/plugins/phonenumber/urls.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

lgarron commented 1 year ago

Thanks for the release!

This is sufficient for installing from pip, but the project front page only lists 1.15.1 as the latest tagged release on GitHub. Do you plan to add newer releases there as well? https://github.com/jazzband/django-two-factor-auth/releases

(If you include release notes in the commit message for a tag, this is also easy to automate with GitHub Actions.)

claudep commented 1 year ago

I'm not a fan of multiple locations for the same functionality. Do we need GitHub releases when we have PyPi? But agree that we should either keep updating it or clean it up altogether.