search

jazzband / django-two-factor-auth

Complete Two-Factor Authentication for Django providing the easiest integration into most Django projects.
MIT License
1.71k stars 448 forks source link

Relaxing django-phonenumber-field version requirement? #639

Closed apkallum closed 1 year ago

apkallum commented 1 year ago

Hello! I wanted to ask if there is a reason why django-phonenumber-field is pinned to below version 7? If there is no reason, could you update the version? I can open a little PR if needed.

claudep commented 1 year ago

Sure, please check the Changelog of django-phonenumber-field to see if any change might impact django-two-factor-auth and then suggest a PR.

claudep commented 1 year ago

@apkallum, gently ping about a PR for this issue

mlec1 commented 1 year ago

@claudep I made an MR to update django-phonenumber-field to v7. I didn't notice any breaking changes affecting this library. The unit tests seem to pass successfully

claudep commented 1 year ago

Fixed by 2b4e8a5fe0b663812009ad3652863cee1d04604f