Closed claudep closed 1 year ago
Merging #645 (1b19109) into master (c53c1b4) will increase coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #645 +/- ##
=======================================
Coverage 95.52% 95.52%
=======================================
Files 78 78
Lines 3351 3353 +2
Branches 377 377
=======================================
+ Hits 3201 3203 +2
Misses 119 119
Partials 31 31
Files | Coverage Δ | |
---|---|---|
two_factor/plugins/webauthn/forms.py | 83.95% <100.00%> (+0.40%) |
:arrow_up: |
..._factor/plugins/webauthn/tests/test_views_setup.py | 100.00% <ø> (ø) |
|
two_factor/plugins/webauthn/utils.py | 67.85% <ø> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Looks like this PR is ready for merge now? @jpaniagualaconich, please give your approval if it's the case.
@claudep It's ready :+1:
Thanks a lot for your contribution.
However, you need to approve the patch formally so as I can merge it.
@claudep I approved it twice now :thinking:
Oh, but maybe you are not a Jazzband member? (https://jazzband.co/) You definitely deserve it! I encourage you to join.
that explains things! :laughing:
thanks! I'm a jazzband member now.
Congrats :medal_sports:
Thanks to Dominik George for the suggestion.