jazzband / django-two-factor-auth

Complete Two-Factor Authentication for Django providing the easiest integration into most Django projects.
MIT License
1.71k stars 448 forks source link

Fixes #634 - Avoid direct dependency on pydantic #645

Closed claudep closed 1 year ago

claudep commented 1 year ago

Thanks to Dominik George for the suggestion.

codecov[bot] commented 1 year ago

Codecov Report

Merging #645 (1b19109) into master (c53c1b4) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #645   +/-   ##
=======================================
  Coverage   95.52%   95.52%           
=======================================
  Files          78       78           
  Lines        3351     3353    +2     
  Branches      377      377           
=======================================
+ Hits         3201     3203    +2     
  Misses        119      119           
  Partials       31       31           
Files Coverage Δ
two_factor/plugins/webauthn/forms.py 83.95% <100.00%> (+0.40%) :arrow_up:
..._factor/plugins/webauthn/tests/test_views_setup.py 100.00% <ø> (ø)
two_factor/plugins/webauthn/utils.py 67.85% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

claudep commented 1 year ago

Looks like this PR is ready for merge now? @jpaniagualaconich, please give your approval if it's the case.

jpaniagualaconich commented 1 year ago

@claudep It's ready :+1:

claudep commented 1 year ago

Thanks a lot for your contribution.

claudep commented 1 year ago

However, you need to approve the patch formally so as I can merge it.

jpaniagualaconich commented 1 year ago

@claudep I approved it twice now :thinking:

claudep commented 1 year ago

Oh, but maybe you are not a Jazzband member? (https://jazzband.co/) You definitely deserve it! I encourage you to join.

jpaniagualaconich commented 1 year ago

that explains things! :laughing:

thanks! I'm a jazzband member now.

claudep commented 1 year ago

Congrats :medal_sports: