Add plivo gateway.

[wieczorek1990]

Added Plivo gateway for SMS.

Description

I added a new module in gateways for sending SMS using the phone number module.

Motivation and Context

Plivo is an alternative to Twilio.

How Has This Been Tested?

Manually tested with use of the setup page and read on the SMS debug page of Plivo.

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [x] My code follows the code style of this project.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [ ] I have added tests to cover my changes.
• [ ] All new and existing tests passed.

[wieczorek1990]

Will add different template.

W dniu wt., 17.10.2023 o 17:22 Claude Paroz @.***> napisał(a):

@.**** requested changes on this pull request.

Thanks for this code! This still needs documentation on how to configure this gateway.

Moreover, I think you cannot simply change the name of the sms template, as people having overridden the template will suddenly see the default template instead of the custom one. I would suggest adding a list of two templates in render_to_string, so the old path is still used if it exists in user projects.

— Reply to this email directly, view it on GitHub https://github.com/jazzband/django-two-factor-auth/pull/672#pullrequestreview-1682664954, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMRLK7GFJD33BTMGDWM4QTX72PDBAVCNFSM6AAAAAA6D7V33WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMOBSGY3DIOJVGQ . You are receiving this because you authored the thread.Message ID: @.***>

[wieczorek1990]

@claudep I do not see a possibility to use two template_name's in render_to_string.

[wieczorek1990]

@claudep Added documentation.

[claudep]

@claudep I do not see a possibility to use two template_name's in render_to_string.

From https://docs.djangoproject.com/en/4.2/topics/templates/#django.template.loader.render_to_string, The name of the template to load and render. If it’s a list of template names, Django uses select_template() instead of get_template() to find the template.

[wieczorek1990]

I do not like this solution. The parameter check only said template_name.

W dniu wt., 17.10.2023 o 17:58 Claude Paroz @.***> napisał(a):

@claudep https://github.com/claudep I do not see a possibility to use two template_name's in render_to_string.

From https://docs.djangoproject.com/en/4.2/topics/templates/#django.template.loader.render_to_string, The name of the template to load and render. If it’s a list of template names, Django uses select_template() instead of get_template() to find the template.

— Reply to this email directly, view it on GitHub https://github.com/jazzband/django-two-factor-auth/pull/672#issuecomment-1766713544, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMRLKY2ZWAT766XJHUBLS3X72TJHAVCNFSM6AAAAAA6D7V33WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRWG4YTGNJUGQ . You are receiving this because you authored the thread.Message ID: @.***>

[wieczorek1990]

@claudep can we go with a separate template?

W dniu wt., 17.10.2023 o 19:13 Łukasz Wieczorek @.***> napisał(a):

I do not like this solution. The parameter check only said template_name.

W dniu wt., 17.10.2023 o 17:58 Claude Paroz @.***> napisał(a):

@claudep https://github.com/claudep I do not see a possibility to use two template_name's in render_to_string.

From https://docs.djangoproject.com/en/4.2/topics/templates/#django.template.loader.render_to_string, The name of the template to load and render. If it’s a list of template names, Django uses select_template() instead of get_template() to find the template.

— Reply to this email directly, view it on GitHub https://github.com/jazzband/django-two-factor-auth/pull/672#issuecomment-1766713544, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMRLKY2ZWAT766XJHUBLS3X72TJHAVCNFSM6AAAAAA6D7V33WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRWG4YTGNJUGQ . You are receiving this because you authored the thread.Message ID: @.***>