jazzband / django-user-sessions

Extend Django sessions with a foreign key back to the user, allowing enumerating all user's sessions.
https://pypi.python.org/pypi/django-user-sessions
MIT License
630 stars 129 forks source link

Implement Jazzband guidelines for django-user-sessions #105

Open jazzband-bot opened 4 years ago

jazzband-bot commented 4 years ago

This issue tracks the implementation of the Jazzband guidelines for the project django-user-sessions

It was initiated by @Bouke who was automatically assigned in addition to the Jazzband roadies.

See the TODO list below for the generally required tasks, but feel free to update it in case the project requires it.

Feel free to ping a Jazzband roadie if you have any question.

TODOs

Project details

Description Extend Django sessions with a foreign key back to the user, allowing enumerating all user's sessions.
Homepage https://pypi.python.org/pypi/django-user-sessions
Stargazers 291
Open issues 17
Forks 79
Default branch master
Is a fork False
Has Wiki False
Has Pages False
Bouke commented 4 years ago

/cc @ricco386

Bouke commented 4 years ago

@jezdez when I add a "Github incoming webhook" on readthedocs, I'm getting the following error:

Could not add webhook for Django User Sessions. Make sure you have the correct GitHub permissions. The project Django User Sessions doesn't have a valid webhook set up, commits won't trigger new builds for this project. See the project integrations for more information.

Any suggestions?

Bouke commented 4 years ago

@jezdez the project uses Transifex to handle translations. How is this typically handled in Jazzband?

Bouke commented 4 years ago

There's a PR pending review to address the branding: #106.

Bouke commented 4 years ago

@jezdez There's currently no-one with admin permissions on this repository. There's currently a faulty status check which is blocking merging PRs. How's that typically setup for jazzband repos?

ricco386 commented 4 years ago

In PR #106 we have started the discussion about transifex public contributors page, and the possibility to drop the support and do a manual translations...

Since the transifex already has some contributors it might be contra-productive to drop the support, because the project might loose someone who is interested in help out but is not entirely technical to do the translations manually. @Bouke do you know if there are only people who have contributed with code, or are there also people who haven't contributed on github?

Since I have volunteered to maintain this project at jazzband I don't mind to create account on transifex and manage there as well... The downside I can see is that transifex contributors wont be listed in the repo...

Bouke commented 4 years ago

Any suggestions on getting the admin permissions resolved? (ping @jezdez)

Bouke commented 4 years ago

Also posted here: https://github.com/jazzband-roadies/help/issues/184

jezdez commented 4 years ago

Losing admin permissions is an expected side effect of this. I'll follow up for the left-over tasks ASAP.

Bouke commented 4 years ago

@jezdez I can’t merge any PRs because the PR checks are failing. I can’t disable the checks as I’m not an admin. Are you the only one who can fix that? https://github.com/jazzband/django-user-sessions/pull/108

Bouke commented 4 years ago

@jezdez I still can’t merge PRs. E.g. https://github.com/jazzband/django-user-sessions/pull/108.

Bouke commented 4 years ago

@jezdez The problem is that the PR checks are not configured correctly. As I have no admin permissions, I can't resolve these problems. Either you fix those permissions, or you make me admin, or you transfer the repository back to me. Your choice :).

https://github.community/t5/How-to-use-Git-and-GitHub/Cannot-merge-PR-quot-some-checks-haven-t-completed-yet-quot-but/m-p/50127#M10871

The solution is easy, but only by someone with admin rights. They need to edit the branch rules and remove the "Expected" checkbox from the two stale checks.

jezdez commented 4 years ago

@Bouke The only things missing from the TODO list above is transferring the Transifex project and setting up the semiautomatic package releases which I would need to know who the project lead(s) should be.

Bouke commented 4 years ago

@jezdez To whom would I transfer Transifex ownership, is there some Jazzband organisation? As an alternative we could just drop Transifex and have translations contributed directly through Github.

@ricco386 Is setting up semiautomatic package releases something that you can take care of? And can @jezdez list you as project lead?

jezdez commented 3 years ago

@Bouke There is a Jazzband team already at Transifex that we've used to translate a few of the Jazzband projects: https://www.transifex.com/jazzband/ It's not very well maintained though, and I'm not sure if it's worth the extra effort. I leave it to @ricco386 to decide which way to go.

jezdez commented 3 years ago

@ricco386 BTW, I've added you as project lead (finally!): https://jazzband.co/projects/django-user-sessions

@Bouke Want me to add you as a fallback?

jezdez commented 3 years ago

Oh, by the way, the code in #126 also adds the missing pieces for the project release semi-automation.