jazzband / django-waffle

A feature flipper for Django
https://waffle.readthedocs.io
BSD 3-Clause "New" or "Revised" License
1.12k stars 258 forks source link

Add support for Django 3.2 #397

Closed con-cat closed 3 years ago

con-cat commented 3 years ago

Addresses #395 Fixes #396

clintonb commented 3 years ago

Since this feature pertains to Django 3.2, please implement #395, and update tox.ini and setup.py.

con-cat commented 3 years ago

Since this feature pertains to Django 3.2, please implement #395, and update tox.ini and setup.py.

@clintonb I've done that, and also updated run.sh to fix RemovedInDjango40Warning: django-admin.py is deprecated in favor of django-admin.

con-cat commented 3 years ago

I've removed the main branch of Django from the tox.ini envlist because of a few things that are incompatible with Django 4.0 causing tests to fail - I think it would make sense to address those separately.

Specifically, I tried replacing ugettext_lazy with gettext_lazy to address the error in the CI run above, but then I received the below error about a migration changing NullBooleanField to BooleanField, which is funny because NullBooleanField should still be ok in historical migrations.

ValueError: Cannot alter field waffle.Flag.everyone into waffle.Flag.everyone - they do not properly define db_type (are you using a badly-written custom field?)