search

jazzband / django-waffle

A feature flipper for Django
https://waffle.readthedocs.io
BSD 3-Clause "New" or "Revised" License
1.13k stars 258 forks source link

Migration `0004` blows up with Django 4 (NullBooleanField?) #411

Open hugorodgerbrown opened 3 years ago

hugorodgerbrown commented 3 years ago

If you run the test suite against Django 4.0a1, it'll fail on setup with the following message:

ValueError: Cannot alter field waffle.Flag.everyone into waffle.Flag.everyone - 
they do not properly define db_type (are you using a badly-written custom field?)

The migration that fails is 0004_update_everyone_nullbooleanfield, which, rather embarrassingly, was added by me when Django dropped the NullBooleanField. (See commit https://github.com/django-waffle/django-waffle/commit/4e365fef4e7c131ca4c344ef5751eeec77da9c86).

It looks like the problem is caused by going from a NullBooleanField (no longer supported) to a BooleanField - which occurs in migration 0004. This situation would not occur in a mature codebase, where this migration has already been applied, however it does appear in test runs where the database is being set up, and will occur for anyone who adds django-waffle if to a Django 4+ project.

I believe the solution is to retrospectively edit the existing migrations to remove the NullBooleanField references. I'll submit a PR just to check it passes CI.

mrxsal commented 1 year ago

I am on Django==1.11.29, and when installing django-waffle, I now get the following error:

waffle.Flag.everyone: (fields.E110) BooleanFields do not accept null values.
        HINT: Use a NullBooleanField instead.

Could it be related to this change?

clintonb commented 1 year ago

@mrxsal Django 1.x has not been supported for quite some time. We cannot help you with those errors. You’ll need to either upgrade Django, or use an older version of Django-Waffle.

mrxsal commented 1 year ago

Thanks. django-waffle==1.0.0 works.