jazzband / django-waffle

A feature flipper for Django
https://waffle.readthedocs.io
BSD 3-Clause "New" or "Revised" License
1.13k stars 258 forks source link

Add support for Django 4.0 #417

Closed Melevir closed 2 years ago

Melevir commented 2 years ago

It would be great if django-waffle is Django 4.0 compatible.

Sadly, new version of Django dropped a lot of deprecated functions, so update required some actions in django-waffle's code.

Here are two problems:

This one because django.conf.urls.url was removed in Django 4.0 and it's imported in waffle/urls.py.

rh0dium commented 2 years ago

Also

If you need help holler!

clintonb commented 2 years ago

@rh0dium a pull request is welcome!

Melevir commented 2 years ago

I see that the main branch works fine with django4. Any plans on the PyPI release?

clintonb commented 2 years ago

@Melevir feel free to open a pull request that adds test support.

Melevir commented 2 years ago

That was my plan, but it turns out, that the only problem, that blocked me from running waffle on django4 was URLs thing, which is resolved in https://github.com/django-waffle/django-waffle/commit/c781c32de8d7e823e54486862ce5f70d2f49da33

What else blocks django-waffle from django4-compatible release? I'll be glad to help.

clintonb commented 2 years ago
clintonb commented 2 years ago

Fixed by #421