search

jazzband / django-waffle

A feature flipper for Django
https://waffle.readthedocs.io
BSD 3-Clause "New" or "Revised" License
1.12k stars 258 forks source link

add support for everyone option to is_active_for_user #491

Closed jdoconnor closed 9 months ago

jdoconnor commented 9 months ago

fixes #401

This adds support of the everyone boolean to is_active_for_user

jwhitlock commented 8 months ago

Should this also return False if everyone is False, and only continue on a per-user check if everyone is None? This is how flag.is_active works:

https://github.com/django-waffle/django-waffle/blob/63444d6f83a3c75a9630a02e32cfe65ac1305b86/waffle/models.py#L282-L285

chess-octane commented 6 months ago

I agree with @jwhitlock . I wonder what are your thoughts @clintonb ?

chess-octane commented 6 months ago

I submitted a PR to tackle that: https://github.com/django-waffle/django-waffle/pull/498