jazzband / geojson

Python bindings and utilities for GeoJSON
https://pypi.python.org/pypi/geojson/
BSD 3-Clause "New" or "Revised" License
905 stars 120 forks source link

Errors method for validating geometry collections. #102

Closed hrfuller closed 6 years ago

hrfuller commented 6 years ago

Closes #101

codecov-io commented 6 years ago

Codecov Report

Merging #102 into master will increase coverage by 0.2%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #102     +/-   ##
=========================================
+ Coverage   78.41%   78.61%   +0.2%     
=========================================
  Files          11       11             
  Lines         315      318      +3     
  Branches       52       54      +2     
=========================================
+ Hits          247      250      +3     
  Misses         58       58             
  Partials       10       10
Impacted Files Coverage Δ
geojson/geometry.py 96.77% <100%> (+0.16%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 14f85ee...4c3dd19. Read the comment docs.

hrfuller commented 6 years ago

Note the any method in the version on the GeometryCollection subclass. The baseclass version wont work because an array of empty strings is truthy.

frewsxcv commented 6 years ago

bors r+

frewsxcv commented 6 years ago

thanks @hrfuller! 🙇

bors[bot] commented 6 years ago

Build succeeded