search

jazzband / geojson

Python bindings and utilities for GeoJSON
https://pypi.python.org/pypi/geojson/
BSD 3-Clause "New" or "Revised" License
905 stars 120 forks source link

Allow constructing one object from another #104

Closed JesseWeinstein closed 6 years ago

JesseWeinstein commented 6 years ago

This is now complete, as far as I know.

The goal is to allow fluid construction of one object from another, i.e. turning multiple Points into Lines, and Lines into Polygons, without having to explicitly unwrap their coordinates.

JesseWeinstein commented 6 years ago

Fixed doctest, please review when you get a chance. Also, I have a suggested change on my previous, closed PR that I'd be grateful for comments on.

codecov-io commented 6 years ago

Codecov Report

Merging #104 into master will increase coverage by 1.26%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
+ Coverage   78.61%   79.88%   +1.26%     
==========================================
  Files          11       11              
  Lines         318      338      +20     
  Branches       54       63       +9     
==========================================
+ Hits          250      270      +20     
  Misses         58       58              
  Partials       10       10
Impacted Files Coverage Δ
geojson/geometry.py 97.56% <100%> (+0.78%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e7bc299...a40c0b2. Read the comment docs.

frewsxcv commented 6 years ago

i'm traveling today. i'll try to review this later tonight or tomorrow morning

frewsxcv commented 6 years ago

just read this over and it all looks great! nice work! 🥇

bors r+

bors[bot] commented 6 years ago

Build succeeded