jazzband / geojson

Python bindings and utilities for GeoJSON

https://pypi.python.org/pypi/geojson/

BSD 3-Clause "New" or "Revised" License

898 stars 120 forks source link

Streamline support for Feature objects in coord mapping utils #130

Closed rayrrr closed 5 years ago

rayrrr commented 5 years ago

Following up on #128

[x] change Feature object geometry in-place in mapping util
[x] conform unit test to rest of test case
[ ] improve docstrings

Codecov Report

Merging #130 into master will increase coverage by 0.24%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
+ Coverage   94.54%   94.78%   +0.24%     
==========================================
  Files          10       10              
  Lines         348      345       -3     
  Branches       70       69       -1     
==========================================
- Hits          329      327       -2     
  Misses         10       10              
+ Partials        9        8       -1

Impacted Files	Coverage Δ
geojson/utils.py	`86.66% <100%> (+0.55%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 813117e...d049655. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #130 into master will increase coverage by 0.24%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
+ Coverage   94.54%   94.78%   +0.24%     
==========================================
  Files          10       10              
  Lines         348      345       -3     
  Branches       70       69       -1     
==========================================
- Hits          329      327       -2     
  Misses         10       10              
+ Partials        9        8       -1

Impacted Files	Coverage Δ
geojson/utils.py	`86.66% <100%> (+0.55%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 813117e...d049655. Read the comment docs.

rayrrr commented 5 years ago

Hi @auvipy, I am the new project lead of this repo. I wanted to include related docstring updates with this PR before merging it; I have a checklist in the PR description denoting that was work yet to be done. Going forward, please do not merge others' PRs in this repo without at least one of the original authors or a project lead saying it is ready to merge. Of course, we always welcome your direct contributions and code reviews. Thank you!