search

jazzband / geojson

Python bindings and utilities for GeoJSON
https://pypi.python.org/pypi/geojson/
BSD 3-Clause "New" or "Revised" License
898 stars 120 forks source link

Add utf-8 support to geojson.dumps #165

Closed rayrrr closed 2 years ago

rayrrr commented 2 years ago

Resolve issue #163

codecov[bot] commented 2 years ago

Codecov Report

Merging #165 (f7ce2b5) into master (f57bc48) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #165   +/-   ##
=======================================
  Coverage   94.85%   94.85%           
=======================================
  Files          10       10           
  Lines         350      350           
  Branches       71       71           
=======================================
  Hits          332      332           
  Misses         11       11           
  Partials        7        7
Impacted Files Coverage Δ
geojson/codec.py 95.23% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f57bc48...f7ce2b5. Read the comment docs.

hugovk commented 2 years ago

I guess I was added as reviewer by mistake: no problem!

If I were to review, I'd suggest also adding a test case which fails without the fix, and passes with it.

Then it helps ensure it keeps working in the future and guards against regressions.