Closed saromanov closed 9 years ago
Awesome! There are a few flake8 issues that travis reported that need to be addressed.
On a side note, what do you think about making this a method on the GeoJSON objects? e.g. my_linestring.is_valid()
? It's not necessary, just a thought. I'll merge this in either way
Ok, great!
from the one side, it would be better. In that case, not need imports, just call geojsonobject.is_valid()
. From the other side, it is pretty optional and it make no sense to set it on every object. And if you write, that it looks nice already now so, i think, i will be not change it :)
In this case, i'll finish with remaining objects, will provide documentation and fix trobles from flake8 output. Hope, to do it in the next 2 or 3 days.
Great, thank you!
Don't forget to add yourself to the credits :)
Well, i think, i'm done. What i've made in the result:
Replaced is not True
to is False
and renamed IsValid
to is_valid
. I agree, that this name is better.
Looks great @saromanov , thank you for your contribution! :D
Just released version 1.2.0 that includes this code. Thanks again!
Ok, great!
Hi! I notice what allows to construct object even if is not valid by specification and i created module for checking validation for objects. Now is something like a "concept"(or very restricted version), because i don't know about needs this for you. No tests and no documentation, but contains two objects
LineString
andMultiLineString
. How it works:The messages is just a copy-paste from specification What do you think about this?