search

jazzband / geojson

Python bindings and utilities for GeoJSON
https://pypi.python.org/pypi/geojson/
BSD 3-Clause "New" or "Revised" License
908 stars 120 forks source link

`long` is also a valid type #57

Closed bennlich closed 9 years ago

bennlich commented 9 years ago

Ahhh drat I forgot they removed the long type in python 3. Is there a way to only do this check in python 2.7?

frewsxcv commented 9 years ago

There's a couple options you could do:

  1. Add six as a dependency and use six.integer_types
  2. Copy the same check that six does.

Option 2 might be preferred because it seems excessive to pull in a whole dependency just for a simple check

bennlich commented 9 years ago

Errr, weird. The six check didn't seem to work?

bennlich commented 9 years ago

kk!

frewsxcv commented 9 years ago

Thanks for your contribution @bennlich !

:dancer:

frewsxcv commented 9 years ago

I just published 1.2.1 that includes your changes. Thanks again!

https://pypi.python.org/pypi/geojson/1.2.1

bennlich commented 9 years ago

Awesome!