search

jazzband / geojson

Python bindings and utilities for GeoJSON
https://pypi.python.org/pypi/geojson/
BSD 3-Clause "New" or "Revised" License
908 stars 120 forks source link

Pythonic code style changes #67

Closed tiktaalik-dev closed 8 years ago

tiktaalik-dev commented 8 years ago

Hello there,

I made minor changes in coding style. On line 28 I grouped in one line the creation of the dictionary for self.properties. And on line 50 I renamed the function to follow traditional naming conventions in Python.

Cheers.

groteworld commented 8 years ago

Please fix failing unit tests.

Thanks!

frewsxcv commented 8 years ago

If you're busy, I can fix them for you, just let me know

tiktaalik-dev commented 8 years ago

Hi Corey and Blake,

Sorry, I didn't notice the name of the function was being referred to from outside of the geojson folder! I don't know how to fix that. I'm still new to git and GitHub. Maybe you'd prefer to reject the changes? I'm okay with that, no hard feelings about it :-)

Cheers, Rodrigo

frewsxcv commented 8 years ago

No worries, I'll take care of it!

frewsxcv commented 8 years ago

Merged in #72. Thanks!