search

jazzband / icalevents

Python module for iCal URL/file parsing and querying.
MIT License
160 stars 72 forks source link

Fix can't compare offset-naive and offset-aware datetimes error #70

Closed kaitlynmcgoldrick closed 3 years ago

kaitlynmcgoldrick commented 4 years ago

Fixes Issue #69

Testing

Remove the new code in icalevents/icalparser.py and run tests, the new test should fail. Put the code back and the test should pass.

codecov[bot] commented 4 years ago

Codecov Report

Merging #70 (31a1b27) into master (89f3cf7) will decrease coverage by 1.83%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
- Coverage   84.86%   83.03%   -1.84%     
==========================================
  Files           4        4              
  Lines         337      330       -7     
  Branches       79       79              
==========================================
- Hits          286      274      -12     
- Misses         27       31       +4     
- Partials       24       25       +1
Impacted Files Coverage Δ
icalevents/icalparser.py 83.40% <100.00%> (-1.50%) :arrow_down:
icalevents/icaldownload.py 71.79% <0.00%> (-6.78%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 89f3cf7...bd4a63f. Read the comment docs.

SkiTheSlicer commented 2 years ago

any chance this will get pushed to pypi anytime soon?

eigenmannmartin commented 2 years ago

I am still waiting for access rights - sorry @SkiTheSlicer