search

jazzband / icalevents

Python module for iCal URL/file parsing and querying.
MIT License
160 stars 72 forks source link

fix: Template on empty/unreadable file exception is a string, not a float #91

Closed RickMeasham closed 2 years ago

RickMeasham commented 2 years ago

Tiny typo with an empty ICS file caused a TypeError exception on the library rather than the intended IOError on the file. Test case included because ... test everything :D

codecov[bot] commented 2 years ago

Codecov Report

Merging #91 (47ade19) into master (d3656af) will increase coverage by 0.56%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage   87.04%   87.60%   +0.56%     
==========================================
  Files           4        4              
  Lines         355      355              
  Branches       92       92              
==========================================
+ Hits          309      311       +2     
+ Misses         22       21       -1     
+ Partials       24       23       -1
Impacted Files Coverage Δ
icalevents/icaldownload.py 83.33% <100.00%> (+4.76%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d3656af...47ade19. Read the comment docs.