jazzband / icalevents

Python module for iCal URL/file parsing and querying.
MIT License
160 stars 72 forks source link

handle timezone and recurring events #95

Closed eigenmannmartin closed 2 years ago

eigenmannmartin commented 2 years ago

reimplementation of #90 closes #89

kudos to @RickMeasham and @tresni

I have manually counted all entries in outlook for the test_cest case. :-)

codecov[bot] commented 2 years ago

Codecov Report

Merging #95 (b7062ab) into master (c368ad8) will increase coverage by 2.18%. The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   87.84%   90.02%   +2.18%     
==========================================
  Files           4        4              
  Lines         362      381      +19     
  Branches       93       97       +4     
==========================================
+ Hits          318      343      +25     
+ Misses         21       17       -4     
+ Partials       23       21       -2     
Impacted Files Coverage Δ
icalevents/icalparser.py 91.00% <93.33%> (+2.85%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c368ad8...b7062ab. Read the comment docs.

patrick-sb commented 2 years ago

Hi @eigenmannmartin - we ran into the same errors that your PR fixes (thanks!), and noticed that it wasn't being merged. We've decided to fork the repo at https://github.com/teamsurfboard/icalevents because we're depending on it in prod - if you'd like to copy your PR over then we'd be happy to merge it.