jazzband / imaplib2

Fork of Piers Lauder's imaplib2 library for Python.
https://imaplib2.readthedocs.io/
MIT License
33 stars 29 forks source link

Jazzband guidelines #23

Closed piyueh closed 3 years ago

piyueh commented 3 years ago

This PR should resolve the following tasks in #13:

The PR only partially resolves the auto-release workflow of GitHub Actions. I added a hook/workflow to integrate the PyPI releasing and GitHub Actions. However, an issue has to be open at https://jazzband.co/roadies/issue to notify the Jazzband roadies. That says, once merged, we need to add the following new task to #13:

piyueh commented 3 years ago

@graingert Would you like to review/merge this PR?

piyueh commented 3 years ago

@graingert I updated them based on the suggestions in commit 34898462be068fd93710ec5b037027ab486494f5. In addition,

  1. I moved the content of tox.ini to pyproject.toml to have fewer configuration files.
  2. tox now by default only runs regular tests. Users have to provide CMD argument --cov to tox if they want to do coverage tests (as shown in test.yml).

Thanks for the suggestions! I learned a lot of new things.

jezdez commented 3 years ago

Hey all, I noticed this is using Coveralls, could you please use Codecov instead to reduce the number of services?