search

jazzband / imaplib2

Fork of Piers Lauder's imaplib2 library for Python.
https://imaplib2.readthedocs.io/
MIT License
33 stars 29 forks source link

Add tests/test_imports.py to sdist #38

Closed derekschrock closed 2 years ago

piyueh commented 2 years ago

Could you provide a description of why the tests should be included in the installation? From my understanding, a source distribution is usually only for installation. For the purpose of development (including testing), I expected them to use the source code directly.

derekschrock commented 2 years ago

Some packaging systems (FreeBSD ports) attempt to use the sdist and have builtin make targets to run unit tests. With the tests in the sdist the testing and building can happen at the same time for that packaging platform.

codecov[bot] commented 2 years ago

Codecov Report

Merging #38 (6518c4b) into master (d16cadf) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #38   +/-   ##
=======================================
  Coverage   12.38%   12.38%           
=======================================
  Files           3        3           
  Lines        1413     1413           
=======================================
  Hits          175      175           
  Misses       1238     1238
Flag Coverage Δ
py3.6 12.38% <ø> (ø)
py3.7 12.40% <ø> (ø)
py3.8 12.43% <ø> (ø)
py3.9 12.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d16cadf...6518c4b. Read the comment docs.

piyueh commented 2 years ago

Got it. Thanks!