search

jazzband / imaplib2

Fork of Piers Lauder's imaplib2 library for Python.
https://imaplib2.readthedocs.io/
MIT License
34 stars 29 forks source link

Use resp_timeout for socket connection #42

Closed c4ffein closed 3 months ago

c4ffein commented 2 years ago

There is actually no easy way to set the timeout for the first socket connection. We could just use the resp_timeout attribute of the IMAP4 class. Otherwise we could add another parameter to __init__.

c4ffein commented 2 years ago

Probably can't be accepted as-is, as we should change the related docstrings, but I wanted to get an opinion first

codecov[bot] commented 2 years ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 12.40%. Comparing base (f6b4056) to head (e79c846). Report is 26 commits behind head on master.

Files with missing lines Patch % Lines
imaplib2/imaplib2.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #42 +/- ## ======================================= Coverage 12.40% 12.40% ======================================= Files 3 3 Lines 1419 1419 ======================================= Hits 176 176 Misses 1243 1243 ``` | [Flag](https://app.codecov.io/gh/jazzband/imaplib2/pull/42/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jazzband) | Coverage Δ | | |---|---|---| | [py3.10](https://app.codecov.io/gh/jazzband/imaplib2/pull/42/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jazzband) | `12.41% <0.00%> (ø)` | | | [py3.6](https://app.codecov.io/gh/jazzband/imaplib2/pull/42/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jazzband) | `12.38% <0.00%> (ø)` | | | [py3.7](https://app.codecov.io/gh/jazzband/imaplib2/pull/42/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jazzband) | `12.40% <0.00%> (ø)` | | | [py3.8](https://app.codecov.io/gh/jazzband/imaplib2/pull/42/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jazzband) | `12.43% <0.00%> (ø)` | | | [py3.9](https://app.codecov.io/gh/jazzband/imaplib2/pull/42/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jazzband) | `12.43% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jazzband#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.