search

jazzband / jsonmodels

jsonmodels is library to make it easier for you to deal with structures that are converted to, or read from JSON.
http://jsonmodels.readthedocs.org/en/latest/
BSD 3-Clause "New" or "Revised" License
334 stars 51 forks source link

Fixing typo in the Length validator #112

Closed DanielSchiavini closed 6 years ago

DanielSchiavini commented 6 years ago

This bug hasn't been reported but it seems an easy typo. Tests should be catching this issue too.

avrahamshukron commented 6 years ago

OMG this is not merely a "typo"... This is an actual bug that enable setting invalid value.

A failing test must be written immediately.

DanielSchiavini commented 6 years ago

Thanks @avrahamshukron for fixing this. I am also encountering problems generating schemas when using Length validator in a ListField. Now that I see the PR was appreciated, should I fix it?

DanielSchiavini commented 6 years ago

Closed the PR because it's moved to https://github.com/beregond/jsonmodels/pull/114

avrahamshukron commented 6 years ago

@DanielSchiavini of course! Although I'm not the maintainer of this package but only a contributor, I know for a fact that @beregond appreciates contributions.

DanielSchiavini commented 6 years ago

Nice, I just created #117