search

jazzband / jsonmodels

jsonmodels is library to make it easier for you to deal with structures that are converted to, or read from JSON.
http://jsonmodels.readthedocs.org/en/latest/
BSD 3-Clause "New" or "Revised" License
334 stars 51 forks source link

Drop support for EOL Python 2.7 and 3.5 #138

Closed hugovk closed 3 years ago

hugovk commented 3 years ago

And upgrade Python syntax with pyupgrade --py36-plus.

codecov[bot] commented 3 years ago

Codecov Report

Merging #138 (d3804b9) into master (bc2e1cd) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #138   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          750       743    -7     
  Branches       156       155    -1     
=========================================
- Hits           750       743    -7
Impacted Files Coverage Δ
jsonmodels/errors.py 100.00% <ø> (ø)
jsonmodels/builders.py 100.00% <100.00%> (ø)
jsonmodels/collections.py 100.00% <100.00%> (ø)
jsonmodels/fields.py 100.00% <100.00%> (ø)
jsonmodels/models.py 100.00% <100.00%> (ø)
jsonmodels/utilities.py 100.00% <100.00%> (ø)
jsonmodels/validators.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bc2e1cd...d3804b9. Read the comment docs.

hugovk commented 3 years ago

These required checks will need to be removed from the branch protection rules:

build (2.7) Expected — Waiting for status to be reported build (3.5) Expected — Waiting for status to be reported build (pypy2) Expected — Waiting for status to be reported

jstockwin commented 3 years ago

I have created https://github.com/jazzband-roadies/help/issues/210 to try and unblock this

jstockwin commented 3 years ago

Required checks changed. Any idea what codecov is complaining about...? (I am not famililar with codecov but I don't see how the coverage would have changed... IMO such a small diff should be acceptable anyway)

beregond commented 3 years ago

@jstockwin this is echo from previous PR, from what I see, so this one is ready to go, I'll provide fix for coverage later

beregond commented 3 years ago

This https://github.com/jazzband/jsonmodels/pull/139 should fix the problem