search

jazzband / jsonmodels

jsonmodels is library to make it easier for you to deal with structures that are converted to, or read from JSON.
http://jsonmodels.readthedocs.org/en/latest/
BSD 3-Clause "New" or "Revised" License
334 stars 51 forks source link

Remove dead code #139

Closed beregond closed 3 years ago

beregond commented 3 years ago

This should improve coverage - I removed two dead code cases, which cannot be reached with regular usage (validation prohibits to reach such state beforehand).

codecov[bot] commented 3 years ago

Codecov Report

Merging #139 (78ffe57) into master (5e8e56b) will increase coverage by 0.52%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #139      +/-   ##
===========================================
+ Coverage   99.47%   100.00%   +0.52%     
===========================================
  Files           8         8              
  Lines         756       750       -6     
  Branches      157       156       -1     
===========================================
- Hits          752       750       -2     
+ Misses          3         0       -3     
+ Partials        1         0       -1
Impacted Files Coverage Δ
jsonmodels/builders.py 100.00% <ø> (+1.32%) :arrow_up:
jsonmodels/models.py 100.00% <100.00%> (+2.10%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5e8e56b...4fba0c2. Read the comment docs.