search

jazzband / jsonmodels

jsonmodels is library to make it easier for you to deal with structures that are converted to, or read from JSON.
http://jsonmodels.readthedocs.org/en/latest/
BSD 3-Clause "New" or "Revised" License
335 stars 51 forks source link

Unpin requirements versions #73

Closed dimakuz closed 7 years ago

dimakuz commented 7 years ago

Hey,

We'd like to use jsonmodels package in Dragonflow, an OpenStack project, to refactor our models [1], [2] and maybe use them to generate JSON-Schema for API. In the process of proposing as jsonmodels as OpenStack requirement [3] a concern was raised that having the requirements pinned to a specific versions can be problematic [4]. If you can help us getting the package accepted would help us a lot!

Thanks!

[1] https://review.openstack.org/#/c/410298/ [2] https://review.openstack.org/#/c/414984/ [3] https://github.com/openstack/requirements/ [4] https://review.openstack.org/#/c/415164/

beregond commented 7 years ago

In general looks ok - just those questions of mine :)

I agree that pinning to versions is problematic - I'm even considering abandoning versions at all (so only libs names stays, as this is lib and not an actual app - this shouldn't be a problem in actual project). What do you think?

dimakuz commented 7 years ago

@beregond I agree, I can submit a patch that gets rid of versions if you'd like.

beregond commented 7 years ago

@dimakuz yes, please, lets try this approach

dimakuz commented 7 years ago

@beregond Take a look when you got a moment

beregond commented 7 years ago

Looks nice :+1: