search

jazzband / jsonmodels

jsonmodels is library to make it easier for you to deal with structures that are converted to, or read from JSON.
http://jsonmodels.readthedocs.org/en/latest/
BSD 3-Clause "New" or "Revised" License
334 stars 51 forks source link

ListField: removed default `None` value for the `items_types` parameter. #97

Open avrahamshukron opened 6 years ago

avrahamshukron commented 6 years ago

This will create more consistent code since item_types is required. Tests had to be modified a bit. Specifically tests which used Model class with circular reference to itself. It was easier to just extract the dummy class outside the function, in order to avoid import path hell.

This change breaks the current API, so if merged it should be into a new major version.

Fixes #96

beregond commented 5 years ago

@avrahamshukron nice, and you are right - therefore lets make version 3 :) before that I need to release some small improvements to branch 2.x and then we will do all BC breaking stuff (this and regexes too)

avrahamshukron commented 5 years ago

Sure, thanks! Please hold the release of 3.0 until the weekend, I might have some more small fixes to push.

beregond commented 5 years ago

Ok, no problem

avrahamshukron commented 5 years ago

I totally forgot about this... If it is still relevant you can absolutely merge this.