Closed johnthagen closed 3 years ago
Hello @johnthagen,
Nice catch! Yes, indeed. White outlined labels would look better on a dark mode.
I'd like to address this issue. @atugushev: Do you mind assigning the issue to me?
@fhightower feel free to send a PR, I've marked you as an assignee.
@fhightower while you're on it, I have a comment to make. I don't like that the picture is PNG. It's much better to have it in SVG. So could you redraw it in vector and keep it in that format?
Also, verify the colors compat/contrast with more than one dark theme — GH has two darks (default and dimmed), and also, there are third-party mods like https://github.com/StylishThemes/GitHub-Dark.
Will do, thanks for the input.
FTR now that there's Sphinx docs including README, we need to also check https://pip-tools.rtfd.io (there's a dark mode toggle at the top-right corner).
I've started working on this and want to get some feedback before going further. I've replicated the current image in an SVG you can see here. I have two questions:
Thanks!
@fhightower that is no longer necessary because this will be closed by #1475. @peymanslh did the work and it's almost ready for merge.
For the future, it's best to start PRs — they are how people get feedback/reviews/discussions on GitHub. If there's no PR, the assumption is that nobody's working on the issue.
Ah, ok - thanks for the feedback @webknjaz .
pip-tools
GitHub pagePerhaps if the black text had a white outline it would help?