Filter out origin ireqs for extra requirements before writing output annotations

jazzband / pip-tools

A set of tools to keep your pinned Python dependencies fresh.

https://pip-tools.rtfd.io

BSD 3-Clause "New" or "Revised" License

7.69k stars 610 forks source link

Filter out origin ireqs for extra requirements before writing output annotations #2011

Closed chrysle closed 10 months ago

chrysle commented 10 months ago

Resolves #2003, closes #2007

Contributor checklist

[x] Included tests for the changes.
[x] PR title is short, clear, and ready to be included in the user-facing changelog.

Maintainer checklist

[x] Verified one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
[ ] Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

AndydeCleyre commented 10 months ago

Thanks!

Minor note on terms, in the pip-tools context: "header" usually refers to the big comment at the top, while the comments this PR affects are "annotations."

chrysle commented 10 months ago

Right, I don't know what moved me to replicating the mistake ;-)

lociii commented 10 months ago

@atugushev When do you expect a new release of pip-tools that includes this compatibility fix? There are situations (e.g. we're using renovate with pip-tools) where you cannot downgrade pip and run into this issue.

jonesbusy commented 7 months ago

There are situations (e.g. we're using renovate with pip-tools) where you cannot downgrade pip and run into this issue.

Same situation here.

Solution I found is to rollback pip3 directly on renovate container (if you are using self hosted)

install-tool python 3.10.13
pip3 install --upgrade pip==23.2.1