Fix for `src-files` not being used when specified in a config file

jazzband / pip-tools

A set of tools to keep your pinned Python dependencies fresh.

https://pip-tools.rtfd.io

BSD 3-Clause "New" or "Revised" License

7.67k stars 608 forks source link

Fix for `src-files` not being used when specified in a config file #2015

Closed csalerno-asml closed 7 months ago

csalerno-asml commented 9 months ago

This PR fixes https://github.com/jazzband/pip-tools/issues/2006

src-files is found in the click context, ctx, but however is not populating the variable src_files, so that it is an empty tuple. For this reason, the tool will then start to select a requirement file, as shown in the linked issue.

Contributor checklist

[x] Included tests for the changes.
[x] PR title is short, clear, and ready to be included in the user-facing changelog.

Maintainer checklist

[x] Verified one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
[ ] Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

webknjaz commented 9 months ago

@csalerno-asml thanks for starting this! This PR would need a regression test to be mergeable. Could you add one?

csalerno-asml commented 9 months ago

Done @webknjaz :)

csalerno-asml commented 9 months ago

@chrysle fine but this PR is open since August https://github.com/jazzband/pip-tools/pull/1966 This one can be merged as-is and then reworked if necessary - or the other one gets a bump

csalerno-asml commented 8 months ago

Any update @chrysle @atugushev @webknjaz ?

webknjaz commented 7 months ago

@csalerno-asml #1966 is approved and will be merged once the CI gets unblocked (it's a repo-global blocker).

chrysle commented 7 months ago

Since that's now merged, could you rebase?

csalerno-asml commented 7 months ago

@chrysle done :)

webknjaz commented 7 months ago

That's not a rebase, though.

csalerno-asml commented 7 months ago

@webknjaz I rebased, but then there was a merge conflict (don't know why), so I just merged main inside this branch. There are no conflicts however, so I don't see it as an issue

webknjaz commented 7 months ago

Well, this will cause a "foxtrot merge".

csalerno-asml commented 7 months ago

@webknjaz re-rebased

chrysle commented 7 months ago

Thanks!

csalerno-asml commented 6 months ago

hey @chrysle , do you know when this fix will be released? do you guys have a schedule, or a release strategy?

webknjaz commented 6 months ago

Not really. There was some shared repo where releases could be requested, I think.

csalerno-asml commented 6 months ago

From what I see, this is done manually? https://github.com/jazzband/pip-tools/pull/1958

atugushev commented 6 months ago

Let's make a release. I'll do it today.

atugushev commented 6 months ago

Released as part of pip-tools v7.4.0.