search

jazzband / pip-tools

A set of tools to keep your pinned Python dependencies fresh.
https://pip-tools.rtfd.io
BSD 3-Clause "New" or "Revised" License
7.67k stars 608 forks source link

Pillow Added Twice to Requirements file #2026

Closed joeyagreco closed 9 months ago

joeyagreco commented 9 months ago

Command: pipreqs --force --mode compat Requirements.txt: 

Pillow~=10.1.0
Pillow~=10.1.0
Requests~=2.31.0
setuptools~=69.0.2

Environment Versions

  1. OS Type: MacOS - Senoma 14.1.1
  2. Python version: 3.12.0
  3. pip version: 23.3.1
  4. pip-tools version: N/A (not installed)

Steps to replicate

  1. Run command listed above
  2. Look at requirements.txt file
  3. Note I am using this for the library sleeper

Expected result

Pillow is only added once

Actual result

Pillow is added twice

AndydeCleyre commented 9 months ago

What provides this preqs command?

joeyagreco commented 9 months ago

@AndydeCleyre There was a typo in my original issue.

I have fixed it now.

preqs -> pipreqs

AndydeCleyre commented 9 months ago

I'm not familiar with the project, but at a glance it doesn't seem to use pip-tools, does it?

I also see what looks like this issue in the preqs tracker: https://github.com/bndr/pipreqs/issues/383

joeyagreco commented 9 months ago

That issue seems to referencing the same thing (and also using Senoma 14), nice!

Also the library has this in the Makefile: https://github.com/joeyagreco/sleeper/blob/1b32b3967f4cff096131bf0c753a29177c9beb74/Makefile#L24

AndydeCleyre commented 9 months ago

Alright, I'm going to close this as it doesn't seem related to pip-tools.