jazzband / pip-tools

A set of tools to keep your pinned Python dependencies fresh.
https://pip-tools.rtfd.io
BSD 3-Clause "New" or "Revised" License
7.67k stars 608 forks source link

Activate prettier-plugin-toml for pre-commit hooks #2053

Open Horstage opened 6 months ago

Horstage commented 6 months ago

In the pre-commit hook, the plugin prettier-plugin-toml is installed, but not used. Plugins must be loaded either via CLI command --plugin or in the configuration file. As there is a configuration file in this project anyways, I added the plugin there.

For more information, see prettier docs.

Contributor checklist
Maintainer checklist
webknjaz commented 6 months ago

Honestly, I think that multiline entries are better. Could you reconfigure it with that in mind?

Horstage commented 6 months ago

I think so too. But sadly prettier-plugin-toml is "still in alpha state". There are no configuration options, nor the possibilty to add an inline ignore...

Maybe we should open up an issue?

webknjaz commented 6 months ago

Maybe so. Otherwise, we could also drop it.

Possible replacements and/or additions to evaluate:

These seem closer to the Python ecosystem, anyway.

Horstage commented 6 months ago

I created an issue for ignoring lines.

Horstage commented 6 months ago

I used the workaround described in the issue to at least ignore the one instance, where multiline would be nicer.

chrysle commented 6 months ago

@Horstage Could you rebase and investigate the pre-commit failure?