Fix ordering of format controls to preserve behavior of pip

jazzband / pip-tools

A set of tools to keep your pinned Python dependencies fresh.

https://pip-tools.rtfd.io

BSD 3-Clause "New" or "Revised" License

7.6k stars 607 forks source link

Fix ordering of format controls to preserve behavior of pip #2082

Closed sethmlarson closed 2 months ago

sethmlarson commented 2 months ago

Contributor checklist

[x] Included tests for the changes.
[x] PR title is short, clear, and ready to be included in the user-facing changelog.

Maintainer checklist

[ ] Verified one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
[ ] Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

Closes #2081

webknjaz commented 2 months ago

@sethmlarson this looks good but could you rewrite the test to use parametrize? It seems to me that this is smashing to standalone tests into the same function which is discouraged.

sethmlarson commented 2 months ago

Thanks for the review @webknjaz, I've restructured the test to use parametrization :)

webknjaz commented 2 months ago

@sethmlarson could you fix the linting offenses (change lists to tuples in tests). I'll enable auto-merge, meanwhile.

sethmlarson commented 2 months ago

@webknjaz Looks like automerge gets disabled if I push, you might have to enable again.

webknjaz commented 2 months ago

No problem! The CI run also needed approval.

webknjaz commented 2 months ago

Looks like compatibility with Pip's main need to be fixed first, which is a blocker. I didn't realize it's not only failing in the nightly runs..

hugovk commented 1 month ago

Thanks for the fix and merge.

We're seeing Dependabot open PRs that break the ordering preventing pip installing successfully. It would be great to have a pip-tools release, would it be possible to make one soon?

Thanks!

webknjaz commented 1 month ago

I don't have enough privileges for this.

cc @atugushev