search

jazzband / prettytable

Display tabular data in a visually appealing ASCII table format
https://pypi.org/project/PrettyTable/
Other
1.35k stars 154 forks source link

The setup.py installation file is missing. #230

Closed Huangxiaodui closed 1 year ago

Huangxiaodui commented 1 year ago

What did you do?

I want to upgrade the prettytable in fedora. But when i use the newest version 3.6.0.tar.gz, the update the version in spec file, build the rpm failed. Because rpmbuild will use python3 setup.py buildand python3 setup.py install to install the package. But there has not setup.py in 3.6.0.

I'd like to confirm why setup.py was deleted? Whether setup.py can be added again to simplify the spec content during RPM package compilation？

Thanks.

What versions are you using?

Please include code that reproduces the issue.

The best reproductions are self-contained scripts with minimal dependencies.

# code goes here
hugovk commented 1 year ago

It was removed in https://github.com/jazzband/prettytable/pull/212 because we switched from setuptools to hatchling as the packaging build backend, making setup.py and setup.cfg redundant.

The metadata is now in pyproject.toml, following modern standards.

No, setup.* won't be added back, please build using pyproject.toml instead.

See https://discuss.python.org/t/tool-to-build-a-rpm-package-backed-by-pep-517/4020?u=hugovk for advice, and on a quick skim, it looks like https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ has also been updated for pyproject.toml.

ofek commented 1 year ago

it looks like https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ has also been updated

Wow that's a really good document, thanks!

Huangxiaodui commented 1 year ago

@hugovk Thank you for your reply, have solved my question, this ISSUE will be closed.