search

jazzband / prettytable

Display tabular data in a visually appealing ASCII table format
https://pypi.org/project/PrettyTable/
Other
1.32k stars 149 forks source link

workflows/test.yml: bump coverage-action to v4 #282

Closed moto-timo closed 5 months ago

moto-timo commented 5 months ago

https://github.com/codecov/codecov-action/releases/tag/v4.0.0

https://github.com/codecov/codecov-action/compare/v3.1.5...v4.0.1

Amongst other things, this also addresses the Nodejs 16 deprecation which was the reason for pinning to v3.1.5

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4095810) 94.38% compared to head (d9645e0) 94.38%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #282 +/- ## ======================================= Coverage 94.38% 94.38% ======================================= Files 5 5 Lines 2404 2404 ======================================= Hits 2269 2269 Misses 135 135 ``` | [Flag](https://app.codecov.io/gh/jazzband/prettytable/pull/282/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jazzband) | Coverage Δ | | |---|---|---| | [macos-latest](https://app.codecov.io/gh/jazzband/prettytable/pull/282/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jazzband) | `94.34% <ø> (ø)` | | | [ubuntu-latest](https://app.codecov.io/gh/jazzband/prettytable/pull/282/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jazzband) | `94.34% <ø> (ø)` | | | [windows-latest](https://app.codecov.io/gh/jazzband/prettytable/pull/282/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jazzband) | `94.30% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jazzband#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

moto-timo commented 5 months ago

I missed the comment in the dependabot v4 bump: https://github.com/jazzband/prettytable/pull/275#issuecomment-1920554223

hugovk commented 5 months ago

Thanks, yes, I think it's better to stick on v3 for a while, to see if things change.

moto-timo commented 5 months ago

Agreed.

moto-timo commented 5 months ago

What might be helpfull is if jazzband could have a organization wide codecov token... but I'm no codecov expert.