jazzband / prettytable

Display tabular data in a visually appealing ASCII table format
https://pypi.org/project/PrettyTable/
Other
1.36k stars 157 forks source link

3.10.0: pytest fails because incorrect module name #285

Closed kloczek closed 7 months ago

kloczek commented 7 months ago
+ /usr/bin/pytest -ra -m 'not network'
============================= test session starts ==============================
platform linux -- Python 3.8.18, pytest-8.0.1, pluggy-1.3.0
rootdir: /home/tkloczko/rpmbuild/BUILD/prettytable-3.10.0
plugins: cov-4.1.0, lazy-fixture-0.6.3
collected 8 items / 1 error

==================================== ERRORS ====================================
__________________ ERROR collecting tests/test_prettytable.py __________________
ImportError while importing test module '/home/tkloczko/rpmbuild/BUILD/prettytable-3.10.0/tests/test_prettytable.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib64/python3.8/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/test_prettytable.py:11: in <module>
    from pytest_lazy_fixtures import lf
E   ModuleNotFoundError: No module named 'pytest_lazy_fixtures'
=========================== short test summary info ============================
ERROR tests/test_prettytable.py
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
=============================== 1 error in 0.31s ===============================

Looks like it should be s/pytest_lazy_fixtures/pytest_lazyfixtures/ https://github.com/tvorog/pytest-lazy-fixture/

hugovk commented 7 months ago

pytest-lazy-fixtures is defined in the tests extra:

https://github.com/jazzband/prettytable/blob/6498a578ba81ccb45d741905d6ef675b1b53a709/pyproject.toml#L37-L42

pytest-lazy-fixture was recently changed to pytest-lazy-fixtures in https://github.com/jazzband/prettytable/pull/279.

kloczek commented 7 months ago

Ha .. lost that last character 😋 Thx 👍