search

jazzband / prettytable

Display tabular data in a visually appealing ASCII table format
https://pypi.org/project/PrettyTable/
Other
1.36k stars 157 forks source link

Fix max table width calculation #289

Closed stuertz closed 6 months ago

stuertz commented 7 months ago

Try to fix max_table_width computation

fixes: #288

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.48%. Comparing base (6498a57) to head (cd8f2b8).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #289 +/- ## ========================================== + Coverage 94.38% 94.48% +0.10% ========================================== Files 5 5 Lines 2404 2431 +27 ========================================== + Hits 2269 2297 +28 + Misses 135 134 -1 ``` | [Flag](https://app.codecov.io/gh/jazzband/prettytable/pull/289/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jazzband) | Coverage Δ | | |---|---|---| | [macos-latest](https://app.codecov.io/gh/jazzband/prettytable/pull/289/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jazzband) | `94.44% <100.00%> (+0.10%)` | :arrow_up: | | [ubuntu-latest](https://app.codecov.io/gh/jazzband/prettytable/pull/289/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jazzband) | `94.44% <100.00%> (+0.10%)` | :arrow_up: | | [windows-latest](https://app.codecov.io/gh/jazzband/prettytable/pull/289/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jazzband) | `94.40% <100.00%> (+0.10%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jazzband#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stuertz commented 7 months ago

Hi @hugovk is something missing here? Are you waiting for something to be added?

hugovk commented 6 months ago

Hi! Thank you very much for the PR! I'm just waiting to find time to review it :) I'll definitely try to get to it this month.

hugovk commented 6 months ago

Thank you very much!