Closed claudep closed 4 years ago
I think there are two options:
django-import-export
wants to support all formats as before, it just has to change its dependencies to include the tablib optional ones.django-import-export
wants to let the user choose the installed dependencies, it should do something similar to this patch, and then check with the tablib registry to know if some format is available or not.I'm happy to help if needed.
Merging #425 into master will increase coverage by
0.09%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #425 +/- ##
=========================================
+ Coverage 89.41% 89.5% +0.09%
=========================================
Files 24 25 +1
Lines 2446 2468 +22
=========================================
+ Hits 2187 2209 +22
Misses 259 259
Impacted Files | Coverage Δ | |
---|---|---|
src/tablib/core.py | 82.61% <100%> (-0.17%) |
:arrow_down: |
src/tablib/formats/__init__.py | 97.14% <100%> (+0.65%) |
:arrow_up: |
tests/test_tablib.py | 98.42% <100%> (+0.01%) |
:arrow_up: |
src/tablib/exceptions.py | 100% <100%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9d2f7d6...f04bc95. Read the comment docs.
Perhaps a pip install tablib[all]
shortcut could install all?
And I think this would warrant a version bump.
So is it valid/acceptable to add a line like 'all': ['odfpy', 'markuppy', 'pandas', 'pyyaml', 'xlrd', 'xlwt', 'openpyxl>=2.4.0'],
in extras_require
?
For the version bump, aren't we going to bump the version for the next release anyway?
So is it valid/acceptable to add a line like
'all': ['odfpy', 'markuppy', 'pandas', 'pyyaml', 'xlrd', 'xlwt', 'openpyxl>=2.4.0'],
inextras_require
?
Yes, something like that. compare what attrs does:
https://github.com/python-attrs/attrs/blob/179b1c4bf0fedaa0e0281649719d1f1e0bd51e94/setup.py#L39-L55
For the version bump, aren't we going to bump the version for the next release anyway?
Yep :)
Merged in 626a062, thanks for the review!
Thank you! It will be great to get rid of all of these dependencies.
I wonder if this is compatible with how django-import-export does things?