Refactor error raising to remove duplication

jazzband / tablib

Python Module for Tabular Datasets in XLS, CSV, JSON, YAML, &c.

https://tablib.readthedocs.io/

MIT License

4.61k stars 593 forks source link

Closed hugovk closed 4 years ago

hugovk commented 4 years ago

This will conflict with https://github.com/jazzband/tablib/pull/437. Shall we merge this before or after that one?

claudep commented 4 years ago

Depends on whether you want to be nice to Daniel :-)

hugovk commented 4 years ago

Rebased!

claudep commented 4 years ago

Could you just squash the first two commits (letting only the pre-commit stuff separate)?

hugovk commented 4 years ago

OK, I can do that later. But won't "Squash and merge" nullify it in any case?

claudep commented 4 years ago

Sure we could do that, but as the pyupgrade commit is not related to the main issue, I would have let it as a separate commit.

hugovk commented 4 years ago

OK to squash and merge instead?

claudep commented 4 years ago

Done :-) Thanks for the patch.