jazzband / tablib

Python Module for Tabular Datasets in XLS, CSV, JSON, YAML, &c.
https://tablib.readthedocs.io/
MIT License
4.61k stars 593 forks source link

Remove unnecessary MANIFEST.in #439

Closed hugovk closed 4 years ago

hugovk commented 4 years ago

When using setuptools_scm, MANIFEST.in is needed when we want to exclude tracked files, or include untracked files.

https://github.com/pypa/setuptools_scm/blob/master/README.rst#file-finders-hook-makes-most-of-manifestin-unnecessary

It doesn't look like we need those, and check-manifest causes the CI to sometimes fail when adding new files, which setuptools_scm will find anyway.

Ping @jezdez

jezdez commented 4 years ago

Ah, huh, that makes total sense, I forgot that setuptools_scm does that. Would you mind -- just for the record -- create a sdist and bdist_wheel with and without the manifest template and compare the file contents?

hugovk commented 4 years ago

Here's the sdist and wheels for master and this PR:

Only expected changes in the sdist

image

image

image

And only expected changes in the wheel (renamed here to .zip for ease of comparison):

image

image

image

image

jezdez commented 4 years ago

You're the best, thanks @hugovk!

hugovk commented 4 years ago

You're welcome! Thanks to @dyve who brought up the issue for Black:

jezdez commented 4 years ago

I think there is a chance that other Jazzband projects have done the same 😬